v1.2.0: advisor is per session and off by default (new and existing sessions); old global setting ignored

This commit is contained in:
Agent committed 2026-10-11 05:16:05 +00:00
1 parent f85f445ef6
commit 0f423e3699
6 files changed
+152 -55

No files matched your search

+14 -6
View File
@@ -14,14 +14,22 @@
Blockers are for real damage or clear wrong turns: destructive commands, secret leaks, pushing broken code, ignoring explicit instructions, going in circles. Concerns cover likely bugs, wrong assumptions, unverified claims, or a much better approach.
## Picking the advisor in the composer
## Per session, off by default
The advisor is chosen **per session**. Every session, new or existing, starts with the advisor **off**. Turning it on, or picking a model, in one session doesn't affect any other.
The plugin adds an **Advisor** control to the composer bar, next to the model picker:
- **Off**: no reviews.
- **Same model as the agent**: the default.
- **Off**: no reviews. This is the default.
- **Same model as the agent**: turns it on with the session's own model.
- **Any model from DSH's model picker**: the same provider-grouped list. **Hover** a model that has reasoning efforts to open a side menu and pick its effort; clicking the model uses its default effort. The keyboard works too (→ opens the effort menu, ← goes back, Esc closes).
The trigger shows the current choice, e.g. `Claude Haiku · Low` or `Advisor off`. The choice is saved on the host (`<profile>/omp-advisor.json`, through `GET`/`POST /omp-advisor/settings`). It applies from the advisor's next review, with no restart, and it overrides `enabled`, `provider`, `model` and `reasoningEffort` from the config below. Picking an advisor never changes the agent's own model.
The trigger shows this session's choice, e.g. `Claude Haiku · Low` or `Advisor off`.
- **Where it's saved:** on the host in `<profile>/omp-advisor/sessions.json`, keyed by session id, through `GET`/`POST /omp-advisor/settings?session=<id>`. The newest 2,000 sessions are kept.
- **When it applies:** from that session's next review, with no restart.
- **What it overrides:** `enabled`, `provider`, `model`, `reasoningEffort` and `minLevel` from the config below, for that session only.
- **What it never touches:** the agent's own model.
Upgrading from 1.1: the old global `<profile>/omp-advisor.json` is ignored, so no session stays on without being turned on again.
## Installation
@@ -29,14 +37,14 @@ The trigger shows the current choice, e.g. `Claude Haiku · Low` or `Advisor off
dsh plugin --profile web add git+https://git.rizzy.dev/DSH-Plugins/omp-advisor.git
```
Or in the Web UI, go to **Settings → Plugins → Install**. For development, use `link:` to a clone. Restart DSH afterwards; new sessions are advised automatically.
Or in the Web UI, go to **Settings → Plugins → Install**. For development, use `link:` to a clone. Restart DSH afterwards, then turn the advisor on in the sessions where you want it.
## Configuration
```yaml
- id: omp-advisor
config:
enabled: true
enabled: false # default for sessions that haven't been switched on in the composer
provider: '' # advisor model route; empty = same as the agent
model: '' # e.g. provider: omni, model: claude-haiku-4-5 for a cheap fast reviewer
reasoningEffort: '' # optional effort for the advisor model